search

zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

fix error nav menu mobile #892

Closed tranjenny closed 3 years ago

tranjenny commented 3 years ago

hello, i fix responsive nav menu mobile

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @tranjenny, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
892 615 181
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
7 198 401
brittneypostma commented 3 years ago

image Hi, there is a template that shows up when you create a pull request similar to the image. It should be filled in with the change being made and linked to an open issue. You link them using the # sign followed by the issue number. You may create an issue to adds value to the site, but please keep the scope smaller. In this pr you are changing 7 files and it is hard to see what is going on. Also, the menu on the left is yours and looks out of alignment compared to how the right is centered. image

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@tranjenny A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@tranjenny A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

brittneypostma commented 3 years ago

Since there has been no communication on this, I am closing for now. Feel free to retry a pr with a linked issue and small change.