zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

Fix Console Errors in Multiple Files & Remove Unneeded Slider Hover Styling for Mobile #900

Closed usafder closed 4 years ago

usafder commented 4 years ago

New Mockup

Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.

No Bootstrap or jQuery

Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊

New Task:

What is the task

Need to remove unnecessary slider hover styling for mobile and also fix below console errors which occur when landing on Home page: 1) File: ..\assets\js\script.js Uncaught TypeError: Cannot set property 'onclick' of null at script.js:49

2) File: ..\assets\js\animate.js Uncaught TypeError: Cannot read property 'querySelectorAll' of null at animate.js:123

Who is the task for?

Confirm all of the following:


⚠️ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM