zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

About Page Styling #904

Closed krishnakanthati closed 3 years ago

krishnakanthati commented 3 years ago

New Mockup

Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.

No Bootstrap or jQuery

Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊

New Task:

What is the task

About Page needs styling.

This is the url: https://keiko-corp.netlify.app/ As one clicks the "More" dropdown menu. And selects the About option or https://keiko-corp.netlify.app/about.html This redirects you to the About page.

In the about page you find that there is a thick white border created when the app is in the dark mode. That white border isn't relevant and is annoying when the user is the in dark mode.

This can be removed with certain CSS styling.

Who is the task for?

Confirm all of the following:


⚠️ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

krishnakanthati commented 3 years ago

I'm working on it.