search

zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

Dark mode color fixes #909

Closed VrajKD closed 3 years ago

VrajKD commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Summarize what this PR fixes:- Wrong colors used in the dark mode for the index page

Pricing card background gets hidden while in Dark Mode. Also, wrong colors used in Dark Mode for the brands section

What ISSUE NUMBER does this fix?

Fixes # 908

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @VrajKD, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
909 36 38
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 198 406
zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @VrajKD, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
909 36 38
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 198 406
brittneypostma commented 3 years ago

Great changes. One note though, when you link your issue, make sure the number is next to the #. It did not link correctly.