zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

dark mode styling #910

Closed krishnakanthati closed 3 years ago

krishnakanthati commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Summarize what this PR fixes:- This PR is basically styling about page. As mentioned in the issue #904 , when one toggles the dark-mode switch the theme changes to dark mode but left a huge side white color boders which was not relevant and needed to be solved.

This PR basically solves the above mentione issue #904 . By erasing the extra white color border which popped out of nowhere when themes were toggled.

It works(looks) much better now. #904

What ISSUE NUMBER does this fix?

Fixes #904

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @krishnakanthati, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
910 28 8
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 198 406
brittneypostma commented 3 years ago

I love how specific your explanation was. Nice job!

krishnakanthati commented 3 years ago

I love how specific your explanation was. Nice job!

Thank you!