zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

Issue#916 fixed navbar toggle button in about us page. #917

Closed dhakshinesh closed 3 years ago

dhakshinesh commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Summarize what this PR fixes:- < Detail what your PR changes/fixes >

What ISSUE NUMBER does this fix?

Fixes #

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @dhakshinesh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
917 64 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 198 409
brittneypostma commented 3 years ago

So, the issue links #916 which is supposed to fix the navbar toggle in about page. However, the files changed reflect a footer being added to the about page. This is fine, but the issue needs to be created, linked, and explained correctly in the pr. Please try to create it again with the correct issue linked.