zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

fix(query-selector): correct parameter in query selector #926

Closed ps011 closed 3 years ago

ps011 commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

This PR fixes an issue with query selector added for the login page. There was an ID and it was queried in the wrong way.

What ISSUE NUMBER does this fix?

https://github.com/zero-to-mastery/Keiko-Corp/issues/925

Fixes #

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @ps011, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
926 2 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 197 408
brittneypostma commented 3 years ago

This actually isn't a needed fix. It is correct as it was, shown below in the MDN example.

image