zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

Fix/888 - Fixed Blog Page to Have Same Header/Sticky Header as Home Page #928

Closed sdangoy closed 3 years ago

sdangoy commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Summarize what this PR fixes:- Previously the blog page had a transparent sticky header. I took the header and sticky header from the home page and placed it in the blog page. It broke the styling of the blog page so I had to also fix that.

What ISSUE NUMBER does this fix?

Fixes #888

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @sdangoy, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
928 219 117
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 197 408
brittneypostma commented 3 years ago

These look like good changes. Unfortunately, someone else was working on the blog page as well and made a pr before you that added images. This caused conflicts with your pr. I suggest running the git pull upstream master command and trying to repair the conflict with the images intact.