zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

Dropdown menu #933

Closed YahyaFazlani closed 4 years ago

YahyaFazlani commented 4 years ago

What issue does this fix?.

Summarize what this PR fixes:- The PR adds the 'more' dropdown menu to the pages that don't have it. It also fixed the dark mode problem on some of the page as when dark mode was enabled, the full page background wouldn't go black. @brittneypostma

Checklist

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
933 315 237
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 198 410
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
933 315 237
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 198 410
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
933 315 237
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 198 410
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
933 315 237
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 198 410
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
933 315 237
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 198 410
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
933 315 237
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 199 414
brittneypostma commented 4 years ago

There is a conflict with the about.html file and there is no issue linked in the pr. Please fix the conflict and and resubmit with an issue linked to the pr.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@YahyaFazlani A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@YahyaFazlani A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@YahyaFazlani A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.