Closed ka-hn closed 3 years ago
🙏 Thanks for your pull request @ka-hn, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
#️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
---|---|---|
957 | 25 | 24 |
📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
---|---|---|
2 | 199 | 414 |
There isn't a duplicate toggle and this changes the placement of it from the mockup. It has a mobile version and a larger version. The mobile circle is a little off in alignment, but otherwise the toggle is fine.
Ok, thank you. However when there are two toggle buttons, one for mobile and one for desktop it causes problems with maintainability and they are also out of synch with each other. If you toggle dark mode when in mobile version and then scale up the screen to make the desktop one appear, they are not synched in how they are visualized. But thank anyways for the review.
Pull Request Template
What issue does this fix?.
Summarize what this PR fixes:- fixes #954
What ISSUE NUMBER does this fix?
Fixes # fixes #954
Checklist
(Add an
x
between the brackets to check the items)