zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

Updated styling issues related to inconsistency for ticket #959 #960

Closed NorahJC closed 3 years ago

NorahJC commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Summarize what this PR fixes:- < Detail what your PR changes/fixes >

What ISSUE NUMBER does this fix?

Fixes #959

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @NorahJC, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
960 33 11
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 199 414
brittneypostma commented 3 years ago

There are some changes in here that would probably be okay, but it completely messed up the layout away from the mockup. This is the current one: image and this is yours: image

It is best to keep changes small and to a file or two to avoid conflicts and allow for incremental changes that don't mess the design up.

NorahJC commented 3 years ago

Np I'll remove the commits that edit that layout