search

zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

Fixed design for the About Us Page #965

Closed VrajKD closed 3 years ago

VrajKD commented 3 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Fixing broken design for the About Us page.

Summarize what this PR fixes:- The About Us page had a broken design with a broken navbar and footer and white padding all around the content. The design has been fixed and the broken navbar issue solved.

What ISSUE NUMBER does this fix?

Fixes #964

https://github.com/zero-to-mastery/Keiko-Corp/issues/964

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @VrajKD, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
965 134 123
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 200 415
brittneypostma commented 3 years ago

There is a conflict in your page if you could take a look at that please.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@VrajKD A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@VrajKD A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @VrajKD, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
965 136 125
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 200 415
zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @VrajKD, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
965 136 125
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 200 415