search

zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

Converted FAQs to Accordion #972

Closed VrajKD closed 4 years ago

VrajKD commented 4 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Converted FAQs to Accordion

Summarize what this PR fixes:- Converting FAQs to an accordion instead of raw text, so that the user sees the answer on clicking on each question.

image

What ISSUE NUMBER does this fix?

Fixes #971

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @VrajKD, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
972 59 17
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
2 200 413
brittneypostma commented 4 years ago

That's a great idea, however, they do not work. I only see the questions and cannot click them to open.

VrajKD commented 4 years ago

@brittneypostma Thanks for pointing that out.😅 Somehow the js file for the accordion to work didn't go through. I've made a new PR #982 with the same. Thank you!