search

zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

Testimonials Section is not Responsive in screens lower than 768px #976

Closed dilmohan11 closed 4 years ago

dilmohan11 commented 4 years ago

New Mockup

Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.

No Bootstrap or jQuery

Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊

New Task:

Testimonials Section is not Responsive in screens lower than 768px!

What is the task

To make the Testimonials Section Responsive with Media Queries!

Who is the task for?

Confirm all of the following:

⚠️ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

seanevans-test commented 4 years ago

Can I take this please?

seanevans-test commented 4 years ago

I created a pull request for this - https://github.com/zero-to-mastery/Keiko-Corp/pull/987 Let me know if there are any issues with this, happy to help :)

seanevans-test commented 4 years ago

Apologies, I've just seen that this ticket wasn't available for someone else to claim.

dilmohan11 commented 4 years ago

I have created the pull request and resolved the issue.