zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

Fixed CSS issue of testimonials section not responsive in screens low… #987

Closed seanevans-test closed 4 years ago

seanevans-test commented 4 years ago

…er than 768px and tidied up code

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.

Testimonials Section is not Responsive in screens lower than 768px https://github.com/zero-to-mastery/Keiko-Corp/issues/976

Summarize what this PR fixes:- I set the width of the #testimonial-carousel .carousel-item to 80% and adjusted the margins, so they don't add up to over 100%. Also I removed some extra margins on this element which were causing issues.

What ISSUE NUMBER does this fix?

Testimonials Section is not Responsive in screens lower than 768px #976 https://github.com/zero-to-mastery/Keiko-Corp/issues/976

Fixes # Fixed the testimonial section not responding on screens smaller than 768px.

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 4 years ago

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization! You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @seanevans-test, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
987 10 20
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 201 416
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @seanevans-test, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
987 10 20
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 203 419
seanevans-test commented 4 years ago

Is it okay to get merged in, as I don't think this issue was resolved fully.

seanevans-test commented 3 years ago

Hi :) is it possible for you to add the "hacktoberfest-accepted" label to this as it's showing up as "pending" in my Hacktoberfest Profile