Closed yashraj2003e closed 3 years ago
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 16 | 1 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 2 | 20 | 57 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 16 | 1 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 2 | 20 | 57 |
zero-to-mastery-bot[bot]
commented
3 years ago @yashraj2003e A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.
Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.
zero-to-mastery-bot[bot]
commented
3 years ago @yashraj2003e A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.
Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.
r4pt0s
commented
3 years ago @yashraj2003e Please resolve all merge conflicts and make sure you are targeting the dev branch of this repo in your PR.
Also, create a issue about what you want like to implement with a basic description and why we need it. Make sure you link the issue to your PR then
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 707 | 23 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 20 | 58 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 707 | 23 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 20 | 58 |
yashraj2003e
commented
3 years ago @yashraj2003e Please resolve all merge conflicts and make sure you are targeting the dev branch of this repo in your PR.
Also, create a issue about what you want like to implement with a basic description and why we need it. Make sure you link the issue to your PR then
Hello sir, thank you for your kindness towards me. I had a doubt that how can i target the dev branch i tried but couldn't figure it, should i create a new pull request ? Thank You.
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 707 | 23 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 20 | 58 |
r4pt0s
commented
3 years ago @yashraj2003e Please resolve all merge conflicts and make sure you are targeting the dev branch of this repo in your PR. Also, create a issue about what you want like to implement with a basic description and why we need it. Make sure you link the issue to your PR then
Hello sir, thank you for your kindness towards me. I had a doubt that how can i target the dev branch i tried but couldn't figure it, should i create a new pull request ? Thank You.
I already changed it to target the dev branch. If you make another PR, make sure that you choose the dev branch of this repo and not the main branch. You can select it while you create the PR. @yashraj2003e
yashraj2003e
commented
3 years ago @yashraj2003e Please resolve all merge conflicts and make sure you are targeting the dev branch of this repo in your PR. Also, create a issue about what you want like to implement with a basic description and why we need it. Make sure you link the issue to your PR then
Hello sir, thank you for your kindness towards me. I had a doubt that how can i target the dev branch i tried but couldn't figure it, should i create a new pull request ? Thank You.
I already changed it to target the dev branch. If you make another PR, make sure that you choose the dev branch of this repo and not the main branch. You can select it while you create the PR. @yashraj2003e
Thank You sir 😊.
zero-to-mastery-bot[bot]
commented
3 years ago @yashraj2003e A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.
Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.
zero-to-mastery-bot[bot]
commented
3 years ago @yashraj2003e A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.
Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.
zero-to-mastery-bot[bot]
commented
3 years ago @yashraj2003e A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.
Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.
zero-to-mastery-bot[bot]
commented
3 years ago @yashraj2003e A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.
Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 102 | 8 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 21 | 58 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 102 | 8 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 21 | 58 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 103 | 9 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 21 | 58 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 103 | 9 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 21 | 58 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @yashraj2003e, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 101 | 82 | 10360 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 11 | 21 | 58 |
r4pt0s
commented
3 years ago @yashraj2003e There are still two things missing.
You can see both things in my review as not resolved
Also, why did you delete the package.lock.json file?
Issue #105