zero-to-mastery / WebBlocks

zero-to-mastery re-usable web component library.
https://zero-to-mastery.github.io/WebBlocks/
MIT License
22 stars 60 forks source link

feat: add input component #34

Closed thucpn closed 3 years ago

thucpn commented 3 years ago

Simple input component

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @thucpn, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
34 197 6195
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 14 24
r4pt0s commented 3 years ago

@thucpn Thanks for contributing to WebBlocks.

A few changes are necessary in order to get this PR merged.

  1. Comment on (issue #16) so that we can assign this issue to you

  2. Add a prop for a pattern. The input component should provide a pattern feature so that whatever gets entered always shows the in the provided pattern.

  3. Close this PR and make a PR to the dev branch instead.