search

zero-to-mastery / breads-client

Keep track of what you read online and see what your friends are reading.
https://www.breads.io/
Other
46 stars 59 forks source link

dark mode #67

Closed mbogdanel closed 3 years ago

mbogdanel commented 3 years ago

Hello, here is my very first contribution and pull request. I will appreciate any feedback.

I followed instruction from https://darkmodejs.learn.uno/ The widget did not change the styles for the navbar and card elements but I used the darkmode--activated class, that is being added to the body, to complete the changes for the navigation and cards. Work done: -CDN and script for darkmode widget in the HTML head -Added navbar--dark className in the Navbar component -styles on bottom of infima.css to override properties of navbar and card elements

darkmode

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@mbogdanel A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 3 years ago

⚠️ MERGE CONFLICT DETECTED!

@mbogdanel A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

aubundy commented 3 years ago

Issue solved with #69