zero-to-mastery / breads-client

Keep track of what you read online and see what your friends are reading.
https://www.breads.io/
Other
46 stars 59 forks source link

Add validator for invalid/empty url #68

Closed shawnk0723 closed 3 years ago

zero-to-mastery-bot[bot] commented 3 years ago

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization! You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @shawnk0723, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
68 37 4
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 30 31
zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @shawnk0723, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
68 41 13
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 31 32
shawnk0723 commented 3 years ago

Refactored validator for invalid/empty url to use addAlert() action to dispatch an error alert message. Attached the screenshots as well. Please let me know if there's any other issues with this update.

validator2

validator1

zero-to-mastery-bot[bot] commented 3 years ago

🙏 Thanks for your pull request @shawnk0723, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
68 41 13
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 31 32