search

zero-to-mastery / breads-client

Keep track of what you read online and see what your friends are reading.
https://www.breads.io/
Other
46 stars 59 forks source link

Default Text Placeholder #72

Open aubundy opened 3 years ago

aubundy commented 3 years ago

The user should see a default text placeholder whenever they don't have any readings, subscriptions, or subscribers. This text should let the user know they haven't read any articles, followed another user, or have any followers.

aubundy commented 3 years ago

Default text placeholder

aubundy commented 3 years ago
Screen Shot 2021-11-15 at 9 17 25 PM

Here's an example whenever a new user signs up and goes to the "Your Reads" page. Nothing is displayed in the readings column, so some type of prompt letting them know where future read articles will appear would be nice. It is the same if a new user goes to the "followers" or "following" pages. The user list is empty, so a card displaying something along the lines of "you don't follow anyone" or "you don't have any followers yet" would be good

mcflav commented 2 years ago

Ok, got it. Sure I will take a stab at it!

mcflav commented 2 years ago

Hello, I updated the code so that when a user goes to their reads page (Your Reads) it displays a message if they have not posted any articles. Please review and let me know if this works. I also had a question on following/followers. How does this get populated? I tried subscribing to another user's page and adding a tag, but my following/followers is still 0.

mcflav commented 2 years ago

Before my update: image

mcflav commented 2 years ago

After my Update: image

aubundy commented 2 years ago

@mcflav thanks! I'll look at the PR more closely tonight

mcflav commented 2 years ago

Hi Austin, Sorry I know it's been a while, but I'm still working on this item. I've actually made some progress, but still have a few things to adjust according to your last request. I went back and reviewed the React portion of a course I took to get the full scope of props. After the review I was able to follow your code better and I'm back working on this item. Once I'm done I will generate another pull request. If I have any questions I will reach out as well. Thanks!

mcflav commented 2 years ago

Hi Austin, I completed the code for the place holder of user with no reads. I did have a few questions in regards to "Friends/ Subscriptions". Currently I can't test when I have a friend without reads as I still don't know how to add friends. I created another test account. However, when I login with my main account and go to the friends page I don't see where I can add the test friend with no reads as a friend. I looked on the Global page as well. Currently the code should show a message if I have no reads and if I go to my friends page it will show a message if they have no reads.

A few side questions: Currently it will show a message my friends have no reads, but with the current code I'm unsure how to handle if I have more the 1 friend and one friend has reads and the other doesn't. Currently friends seemed to be tracked by subscriptions and this seems to apply to all friends. Also, if I have no friends at all not sure if a message should be displayed. Are we only looking to display a message if we have friends without reads? I will be submitting a pull request shortly so you can see what I have thus far. Thanks!

mcflav commented 2 years ago

Hi Austin, I just completed an updated pull request. The screenshots are the same as above (no changes to how the data is displayed on the site). However, I did update the InitialzationCard component to call the VirtualizedList component to avoid duplicate code.

image

aubundy commented 2 years ago

@mcflav Thanks for doing this! I hope to get around to reviewing this soon but it might take awhile. Just wanted to give a heads up

mcflav commented 2 years ago

Great. No worries, that's fine.

From: Austin Bundy @.> Sent: Thursday, February 17, 2022 12:04 PM To: zero-to-mastery/breads-client @.> Cc: mcflav @.>; Mention @.> Subject: Re: [zero-to-mastery/breads-client] Default Text Placeholder (#72)

@mcflavhttps://github.com/mcflav Thanks for doing this! I hope to get around to reviewing this soon but it might take awhile. Just wanted to give a heads up

— Reply to this email directly, view it on GitHubhttps://github.com/zero-to-mastery/breads-client/issues/72#issuecomment-1043193812, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMTKVE4PWAXRVQIYYU5AB5TU3UTC7ANCNFSM43CJMBGA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>