Closed mcflav closed 3 years ago
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @mcflav, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 97 | 161 | 85 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 3 | 47 | 54 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @mcflav, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 97 | 161 | 85 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 3 | 47 | 55 |
zero-to-mastery-bot[bot]
commented
3 years ago 🙏 Thanks for your pull request @mcflav, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!
Some of the most popular are
| #️⃣ PR Number: | ➕ Line Additions: | 🗑️ Line Deletions: |
|---|---|---|
| 97 | 161 | 85 |
| 📑 Files Changed: | ⭐ Repo Stars: | 🔱 Total Forks: |
|---|---|---|
| 3 | 47 | 55 |
mcflav
commented
3 years ago This has been completed. Please view. Thanks!
From: Austin Bundy @.> Sent: Saturday, October 16, 2021 3:53 PM To: zero-to-mastery/breads-client @.> Cc: mcflav @.>; Mention @.> Subject: Re: [zero-to-mastery/breads-client] Breads client update (#97)
@aubundy commented on this pull request.
In src/features/globalReadings/components/ListItem.tsxhttps://github.com/zero-to-mastery/breads-client/pull/97#discussion_r730306161:
@@ -109,8 +109,15 @@ const ListItem: React.FunctionComponent
= ({ <img loading="lazy" src={newReadingImage}
- onError={(e) => {
Can you move this anonymous function inside imageOnErrorHandler() and then move that function to be within ListItem below getImageDimensions()?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/zero-to-mastery/breads-client/pull/97#pullrequestreview-781385651, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMTKVE32MZENFAVVS2OQNW3UHHJZ5ANCNFSM5GBCPUSA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
mcflav
commented
3 years ago This has been completed. Please review, thanks!
From: Austin Bundy @.> Sent: Saturday, October 16, 2021 3:53 PM To: zero-to-mastery/breads-client @.> Cc: mcflav @.>; Mention @.> Subject: Re: [zero-to-mastery/breads-client] Breads client update (#97)
@aubundy commented on this pull request.
In src/features/globalReadings/components/ListItem.tsxhttps://github.com/zero-to-mastery/breads-client/pull/97#discussion_r730306202:
onLoad={measure}
- alt="Article"
- // alt='Article'
Please remove this comment
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/zero-to-mastery/breads-client/pull/97#pullrequestreview-781385681, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMTKVEYNXTII4FKRIANBLE3UHHJ3LANCNFSM5GBCPUSA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
aubundy
commented
3 years ago Moved to #99
Fixes #87