zero-to-mastery / breads-server

Server code for Breads. Keep track of what you read online, and see what your friends are reading.
https://www.breads.io/
Other
13 stars 29 forks source link

Full Unicode in db #49

Closed aubundy closed 2 years ago

aubundy commented 3 years ago

Some articles will have emojis in either the title or description, but the db is not set up for full unicode support, so these articles can't be saved to the db. We need to transition from utf8 to utf8mb4 tables

Resources:

aubundy commented 3 years ago

Full Unicode in db

Areezy commented 3 years ago

Hello! can I work on this ? I have read the resources you provided above and the contribution guide of course.

aubundy commented 3 years ago

@Areezy Yes, thank you! I'll add you as the assignee

Areezy commented 3 years ago

My approach to this is creating a new sql file which alters the tables to add support for utf8mb4 characters. Is that okay?

aubundy commented 3 years ago

Yes, that would be great. In the PR message, could you also write up an ALTER TABLE statement that accomplishes the same thing? I will need to use it to update the production db

Areezy commented 3 years ago

The plan was to add those alter table statements in the new file I would create. So you could just grab all the statements from there and run it on the production db. Would it still be necessary to add them to the PR message ?

aubundy commented 3 years ago

@Areezy no need to add them to PR message. I did just request a change if you want to take a look

Areezy commented 3 years ago

Okay, I am taking a look now