search

zero01101 / openOutpaint

local offline javascript and html canvas outpainting gizmo for stable diffusion webUI API 🐠
MIT License
507 stars 44 forks source link

Win hooks - basics #141

Closed seijihariki closed 1 year ago

seijihariki commented 1 year ago

Attempts to write some tests on #132.

Trying to meddle with some LF/CRLF quirks, as those change the file hashes used for cache busting.

zero01101 commented 1 year ago

lmao how DARE you, i was writing .bat scripts myself and then you're all like "i don't even manually use lint script" and i'm all "well fine then, i guess i won't either" but here you are with .bat scripts

seijihariki commented 1 year ago

Haha! I still don't use manual lint scripts, but git hooks are an entirely different story, as they pertain to actual cache busting requirements!

You may see that even here we have no lint.bat or lint.ps1 in sight.

seijihariki commented 1 year ago

If you could test this and check that everything works alright (hashes are calculated okay and everything).

seijihariki commented 1 year ago

And good one on reminding me of the .bat files. We are mostly using .ps1 files, the bat was just some early attempts. Will be removing the .bat.

zero01101 commented 1 year ago

added some tiny adjustments, should ignore node_modules directory now and call the .ps1 script from pre-commit :) seemed to hash identically to .sh script 👍

seijihariki commented 1 year ago

Okay, will be merging this into main!