search

zero01101 / openOutpaint

local offline javascript and html canvas outpainting gizmo for stable diffusion webUI API 🐠
MIT License
500 stars 43 forks source link

Support for CFG Rescale extention #260

Closed Kadah closed 8 months ago

Kadah commented 10 months ago

My attempt to add support for CFG Rescale extention. Works, most of the time, but I've likely missed and/or screwed up somethings since I was making some guesses on how to do this. :)

Also filing a bug report for extension detection being wonky and sometimes needed a couple reloads to work. Edit: https://github.com/zero01101/openOutpaint/issues/261

zero01101 commented 8 months ago

disclaimer: apologies for the extended delay, my brain is terrible and you shouldn't expect much from me

so i apologize also right off the bat, but i don't think i'll be merging this, even though your work looks perfectly good and is appreciated - the built-in extension is extremely minimal on purpose and targets specifically 2 of the most popular extensions with very exposed and simple "API" support - my mention of it being janky and pull requests welcomed was poorly worded but in the context of supporting the extensions in the first place :/

i do appreciate your PR however, and again apologize for wasting your time and effort

Kadah commented 8 months ago

No worries, I had forgotten about this till yesterday and was actually gonna come back and close it. I came up with a more universal workaround within the cfg rescale extension itself (shoved it in to an arg within the prompt).

There really needs to be a better and more universal way for extensions to be supported over the API, but that's an upstream problem. xD