search

zeroasterisk / MeteorRider

PhoneGap/Cordova + Meteor integration approach "DOM hijacking", telling PhoneGap where to get content from, letting Meteor hijack your PhoneGap app's HTML/CSS/JS
MIT License
183 stars 28 forks source link

Hot pushing losing cordova context #23

Closed mstn closed 10 years ago

mstn commented 10 years ago

I copied this file https://github.com/zeroasterisk/MeteorRider/blob/master/meteor/startup.js into my meteor app, but it does not work.

Looking at the code, I do not understand what it does. Is it outdated?

Thanks.

mstn commented 10 years ago

In commit https://github.com/zeroasterisk/MeteorRider/commit/b38c3b1d4fd4679b33f6150c120491cab4035730 was introduced a new method because Meteor._reload.onMigrate was deprecated.

In my environment

Meteorite version 0.7.3 Release 0.8.2

Meteor._reload.onMigrate is not deprecated anymore.

I do not understand where phonegapapp.meteorRider(); comes from and what it is supposed to do. Perhaps is it old code?

mstn commented 10 years ago

I think to have understood. Variable phonegapapp was a reference to the object defined here https://github.com/zeroasterisk/MeteorRider/blob/b4e2e44a1dcdebaf7860e486b0098de181b54de6/www/js/phonegapapp.js

In other words, onMigrate should call meteorrider.init, right?

mstn commented 10 years ago

Pull request created https://github.com/zeroasterisk/MeteorRider/pull/24

zeroasterisk commented 10 years ago

you fixed this in your pull request #24