zeroc-ice / datastorm

Data centric pub/sub framework based on Ice
GNU General Public License v2.0
13 stars 7 forks source link

Unused connect callbacks #23

Open pepone opened 1 month ago

pepone commented 1 month ago

https://github.com/zeroc-ice/datastorm/blob/fba29e653d53d3493c423ad1f853f4bee15952cd/cpp/src/DataStorm/SessionI.h#L365

The SessionI object has a collection of connect callbacks, but seems it is always empty:

jose@mac datastorm % rg _connectedCallbacks    
cpp/src/DataStorm/SessionI.cpp
512:        assert(_connectedCallbacks.empty());
565:    for(auto c : _connectedCallbacks)
569:    _connectedCallbacks.clear();
771:    for(auto c : _connectedCallbacks)
775:    _connectedCallbacks.clear();

cpp/src/DataStorm/SessionI.h
365:    std::vector<std::function<void(std::shared_ptr<DataStormContract::SessionPrx>)>> _connectedCallbacks;