Converted iOS demos to SwiftUI and updated folder structure

zeroc-ice / ice-demos

Sample programs for Ice

https://zeroc.com

GNU General Public License v2.0

325 stars 217 forks source link

Converted iOS demos to SwiftUI and updated folder structure #147

Closed ReeceHumphreys closed 2 years ago

ReeceHumphreys commented 2 years ago

The goal of this PR is to update the iOS demos to SwiftUI. Not only does this allow for the demos to be more modern, but it also comes with the benefits of automatic dark mode, support for macOS catalyst, and easier to manage views.

Additionally, the following restructuring was performed:

The hello demo was split into two versions, one that uses Ice discovery and a version that does not.
The library demo was not illustrating anything that the chat or hello did not already accomplish, so it was removed
The chat demo was moved to the root of the swift directory to match the other languages.

Closes #95

ReeceHumphreys commented 2 years ago

There is a missing commit for the hello demos from when I split them into two. Will be adding that commit. Currently it is just two copies of the Unified hello demo before the split.

InsertCreativityHere commented 2 years ago

It looks like the swift demo's README (swift/README.md) needs to be updated.

On line 16, it mentions the iOS directory, which this PR deletes. And it doesn't mention the new Chat directory which this PR adds.

You should remove the message for iOS and add a message for Chat. You can probably just copy the old message that used to be in swift/iOS/README.md with some minor changes.