Open bernardnormier opened 1 year ago
The recommended shutdown procedure for a server is to shut it down before destroying it. In some demos, the server is correctly shut down, for example:
https://github.com/zeroc-ice/ice-demos/blob/7d29cb7548a7c805d2a5fc612f1e7b2417e49bff/cpp11/Ice/hello/Server.cpp#L37
In other demos, the server is just destroyed. While it doesn't matter for those demos, it's not the recommended style:
https://github.com/zeroc-ice/ice-demos/blob/7d29cb7548a7c805d2a5fc612f1e7b2417e49bff/csharp/Ice/hello/Server.cs#L24
We should also consider not using communicator.waitForShutdown() in demos with no shutdown operation. All we need is a "WaitForCtrlC()".
communicator.waitForShutdown()
The recommended shutdown procedure for a server is to shut it down before destroying it. In some demos, the server is correctly shut down, for example:
https://github.com/zeroc-ice/ice-demos/blob/7d29cb7548a7c805d2a5fc612f1e7b2417e49bff/cpp11/Ice/hello/Server.cpp#L37
In other demos, the server is just destroyed. While it doesn't matter for those demos, it's not the recommended style:
https://github.com/zeroc-ice/ice-demos/blob/7d29cb7548a7c805d2a5fc612f1e7b2417e49bff/csharp/Ice/hello/Server.cs#L24
We should also consider not using
communicator.waitForShutdown()
in demos with no shutdown operation. All we need is a "WaitForCtrlC()".