zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2.04k stars 593 forks source link

Java's `Ice/translator` Tests are not Run (and are out of date) #2020

Open InsertCreativityHere opened 7 months ago

InsertCreativityHere commented 7 months ago

These tests seem to be checking the java mapping, with an emphasis on the module->package mapping.

But, these tests are clearly never run. They aren't in the gradle file: https://github.com/zeroc-ice/ice/blob/main/java/test/slice.gradle

And the actual test files are littered with old Slice constructs: https://github.com/zeroc-ice/ice/blob/8f6f3e2c531fe078002a2d77b4d072df801d2471/java/test/Ice/translator/Underscore.ice#L12-L17 And classes implementing interfaces: https://github.com/zeroc-ice/ice/blob/8f6f3e2c531fe078002a2d77b4d072df801d2471/java/test/Ice/translator/SingleModuleWithPackage.ice#L43-L45 And other things that were removed a while ago.


We should either: 1) Update these tests, and start actually running them, or 2) Remove them

InsertCreativityHere commented 7 months ago

Just for the record, when I try to compile these Slice files manually, they indeed generate a bunch of syntax errors.

externl commented 7 months ago

Should we also fix on 3.7?

InsertCreativityHere commented 7 months ago

Should we also fix on 3.7?

I don't see why not.

pepone commented 7 months ago

I believe these were compile-only tests. We should test these using our standard tests, which we compile and execute.

For example Underscore.ice was there to ensure that you can use underscores in identifiers, most of the rest seems related to module/package mapping.

InsertCreativityHere commented 7 months ago

Ah, it'd make sense if they weren't pulling along into the new testing system then.

Seems like the consensus is that we should keep these tests, update/remove their old Slice definitions, and add them back into the gradle testing? Even if only as a compile-test.