zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2.04k stars 593 forks source link

JavaScript build failure with Node 22 #2080

Closed externl closed 4 months ago

externl commented 6 months ago

A new Node.js (v22) was released yesterday.

Likely also affects 3.7

❯ make
npm install --omit=optional

up to date, audited 518 packages in 1s

11 vulnerabilities (1 low, 3 moderate, 7 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm run build

> ice@3.8.0-alpha0 build
> gulp

[15:53:21] Using gulpfile ~/Developer/zeroc-ice/ice/js/gulpfile.js
[15:53:21] Starting 'default'...
[15:53:21] Starting 'build'...
[15:53:21] Starting 'dist'...
[15:53:21] Starting 'ice:dist'...
[15:53:21] Starting 'glacier2:dist'...
[15:53:21] Starting 'icestorm:dist'...
[15:53:21] Starting 'icegrid:dist'...
[15:53:21] Starting 'ice:generate'...
[15:53:21] Starting 'glacier2:generate'...
[15:53:21] Starting 'icestorm:generate'...
[15:53:21] Starting 'icegrid:generate'...
(node:67038) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
[15:53:21] Finished 'icestorm:generate' after 53 ms
[15:53:21] Starting 'icestorm:lib'...
[15:53:21] Finished 'icestorm:lib' after 20 ms
[15:53:21] Starting 'icestorm:lib-min'...
[15:53:21] 'icestorm:lib-min' errored after 39 ms
[15:53:21] TypeError: Cannot assign to read only property 'atime' of object '#<Stats>'
    at onFutimes (/Users/joe/Developer/zeroc-ice/ice/js/node_modules/vinyl-fs/lib/file-operations.js:258:27)
    at FSReqCallback.oncomplete (node:fs:188:23)
    at FSReqCallback.callbackTrampoline (node:internal/async_hooks:130:17)
[15:53:21] 'icestorm:dist' errored after 113 ms
[15:53:21] 'dist' errored after 114 ms
[15:53:21] 'build' errored after 114 ms
[15:53:21] 'default' errored after 115 ms
make: *** [all] Error 1
pepone commented 4 months ago

I fixed the failure. There is still a warning for using deprecated fs.Stats, see https://github.com/orgs/gulpjs/discussions/2809