search

zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2.04k stars 592 forks source link

Document or remove undocumented IceGrid.Registry.RequireXXXCertCN #2135

Closed externl closed 4 months ago

externl commented 5 months ago

I can't find any documentation for these properties and I'm not sure how useful they are. These days CN is not that relevant for hostname verification.

https://github.com/zeroc-ice/ice/blob/aae5161459b914c72afdeb4f5f102a2ae9c752b8/config/PropertyNames.xml#L530-L531

I'm in favor of removing these.

bernardnormier commented 5 months ago

If we remove them, we should also remove the associated code in IceGrid.

pepone commented 4 months ago

@externl I added a fix for this in https://github.com/zeroc-ice/ice/pull/2144 because this allows keeping DistinguisedName internal.

pepone commented 4 months ago

Fixed in https://github.com/zeroc-ice/ice/pull/2144