search

zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2.04k stars 592 forks source link

Reformat C++ code in PHP mapping #2249

Closed bernardnormier closed 4 months ago

bernardnormier commented 4 months ago

clang-format does not understand well the PHP macros and the resulting formatting is very odd looking.

For example:

                                                                        ice_getCompress,
                                                                        ice_void_arginfo,
                                                                        ZEND_ACC_PUBLIC)
                                                                        ZEND_ME(
                                                                            Ice_ObjectPrx,
                                                                            ice_invocationTimeout,
                                                                            Ice_ObjectPrx_ice_invocationTimeout_arginfo,
                                                                            ZEND_ACC_PUBLIC)
                                                                            ZEND_ME(
                                                                                Ice_ObjectPrx,
                                                                                ice_getInvocationTimeout,
                                                                                ice_void_arginfo,
                                                                                ZEND_ACC_PUBLIC)
                                                                                ZEND_ME(
                                                                                    Ice_ObjectPrx,
                                                                                    ice_connectionId,
                                                                                    Ice_ObjectPrx_ice_connectionId_arginfo,
                                                                                    ZEND_ACC_PUBLIC)
                                                                                    ZEND_ME(
                                                                                        Ice_ObjectPrx,
                                                                                        ice_fixed,
                                                                                        Ice_ObjectPrx_ice_fixed_arginfo,
                                                                                        ZEND_ACC_PUBLIC)

We should fix this.