search

zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2k stars 592 forks source link

Remove browser bundles and TypeScript tests #2260

Closed pepone closed 1 month ago

pepone commented 1 month ago

This PR removes support for browser bundles and IIFE (Immediately Invoked Function Expression) modules. Additionally, it includes cleanup of files that were previously generated from local Slice.

Ice remains a CommonJS module. The next step will be to convert Ice to an ES6 module and subsequently remove support for CommonJS modules.

bernardnormier commented 1 month ago

I don't think we should remove all the TypeScript tests, because we need to test somewhere we provide or generate expected/usable TypeScript definitions.

Removing the TypeScript tests would definitely reduce our test coverage.

Maybe we should remove the (duplicated) JavaScript tests. The TS test for feature F presumably tests both the TS API for F, the runtime behavior for F (in JS) and indirectly the JS API.