zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2k stars 592 forks source link

Rename 'SmallStruct' to 'LargeStruct'. #2267

Closed InsertCreativityHere closed 1 month ago

InsertCreativityHere commented 1 month ago

2211 off-handedly renamed one of our structs in the Ice/stream test from SmallStruct to LargeStruct.

We decided to spin that change off into it's own PR. That's what this PR is.

While these terms are ultimately relative, this struct has 11 fields, whereas in every other test we use the name SmallStruct it contains a single field, usually a single byte. So relative to our other structs, it's actually fairly large.

I was motivated to change the name because when removing optional classes, I completely skipped over this type: "there's no way a small struct would hold a class" (it did).


For some reason the Java version of this test is out of parity with all the others... I'm not sure why, but I didn't want to tackle it in this PR.