zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2k stars 592 forks source link

Remove `includeOptional` Flags from Various Class-Related Functions #2271

Closed InsertCreativityHere closed 3 weeks ago

InsertCreativityHere commented 1 month ago

Within the compiler, we have a handful of functions for determining whether something uses/sends/returns classes. Some of these had an includeOptional flag which is dead now; since there's no longer any optional classes to include!

These functions were almost always called with false anyways. The flag was added in 493caea19fd83663eb03b4eeaf7714f99ac07b97 to fix a bug with the scripting languages.

We also had analogs of these functions in the wrapper languages. I slightly cleaned them up while I was searching around.