search

zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2.04k stars 592 forks source link

Fix MATLAB Test Discovery Logic #2386

Closed InsertCreativityHere closed 3 months ago

InsertCreativityHere commented 3 months ago

This nanoscopic PR fixes #2385 by changing 1 letter.

InsertCreativityHere commented 3 months ago

And now CI does indeed show that all 17 tests are running:

 *** [1/17] Running matlab/Slice/escape tests ***
...
InsertCreativityHere commented 3 months ago

Looks like the proxy test is broken. This was one of the tests which was previously being ignored, so who knows how long it's been broken for...

*** [14/17] Running matlab/Ice/proxy tests ***
...
testing opaque endpoints... Error using Ice.ObjectPrx/ice_ping (line 185)
::Ice::ConnectTimeoutException

Error in AllTests.allTests (line 818)
                p1.ice_encodingVersion(Ice.EncodingVersion(1, 0)).ice_ping();

Error in Client (line 15)
    myClass = AllTests.allTests(helper);

Error in runTest (line 28)
        Client(varargin);