Closed InsertCreativityHere closed 3 months ago
Now that we've removed all the *F.ice files, we no longer need to filter them out in the gradle build system.
*F.ice
It also looked like we're specifying a nested srcDir for the plugins test? So I removed it. Before removing this, I couldn't get the VSCode extension to correctly load the projects. This removal seems to of had no impact on the build/tests, but it does look like this recursiveness was intentionally added 10 years ago: https://github.com/zeroc-ice/ice/commit/310ebbba56f3a069f4f7f2b6244f9da05e67e3ef#diff-ee23610eaafcce0a64b45b457ed96fbc58eb8bb17e8adc84adc8d56a7c4941ed
Any ideas why we'd do this?
It's nested because the testPlugins project root is java/test/plugins, and we're also setting this folder as the srcDir. It's also just weird looking. The source directory should be java/test/plugins/src/main/java, just like everything else we do.
testPlugins
java/test/plugins
srcDir
java/test/plugins/src/main/java
Now that we've removed all the
*F.icefiles, we no longer need to filter them out in the gradle build system.It also looked like we're specifying a nested srcDir for the plugins test? So I removed it. Before removing this, I couldn't get the VSCode extension to correctly load the projects. This removal seems to of had no impact on the build/tests, but it does look like this recursiveness was intentionally added 10 years ago: https://github.com/zeroc-ice/ice/commit/310ebbba56f3a069f4f7f2b6244f9da05e67e3ef#diff-ee23610eaafcce0a64b45b457ed96fbc58eb8bb17e8adc84adc8d56a7c4941ed
Any ideas why we'd do this?
It's nested because the
testPluginsproject root isjava/test/plugins, and we're also setting this folder as thesrcDir. It's also just weird looking. The source directory should bejava/test/plugins/src/main/java, just like everything else we do.