Now that I've gotten most of the Java tooling settled out, we can use it for detecting lint violations.
This PR fixes all the easy lint violations that it found, mostly just dead/redundant code.
The most notable is that we were adding java.io.Serializable to Slice-generated enums.
This is useless though, since all enums are already Serializable by default.
The main take-away from the linter is that parts of IceGridGUI are very deprecated, should we care to fix it?
Now that I've gotten most of the Java tooling settled out, we can use it for detecting lint violations. This PR fixes all the easy lint violations that it found, mostly just dead/redundant code.
The most notable is that we were adding
java.io.Serializableto Slice-generated enums. This is useless though, since all enums are alreadySerializableby default.The main take-away from the linter is that parts of
IceGridGUIare very deprecated, should we care to fix it?