Use getIceProperty methods

[bernardnormier]

There are many spots in the code where we should use getIcePropertyXxx but we don't. That's true for all language mappings.

For example:

bernard@studio src % rg -F "getPropertyAsIntWithDefault(\"Ice"
IceGrid/IceGridRegistry.cpp
103:    if (!nowarn && properties->getPropertyAsIntWithDefault("Ice.ThreadPool.Server.Size", 0) > 0)

Ice/Network.cpp
1352:    int32_t rcvSize = instance->properties()->getPropertyAsIntWithDefault("Ice.TCP.RcvSize", dfltBufSize);
1353:    int32_t sndSize = instance->properties()->getPropertyAsIntWithDefault("Ice.TCP.SndSize", dfltBufSize);

IceGrid/IceGridNode.cpp
267:    if (!nowarn && properties->getPropertyAsIntWithDefault("Ice.ThreadPool.Server.Size", 0) > 0)

IceGrid/RegistryI.cpp
1094:    return properties->getPropertyAsIntWithDefault("IceGrid.Registry.Client.Connection.IdleTimeout", idleTimeout);

Ice/ios/StreamAcceptor.cpp
129:    _backlog = instance->properties()->getPropertyAsIntWithDefault("Ice.TCP.Backlog", SOMAXCONN);
131:    _backlog = instance->properties()->getPropertyAsIntWithDefault("Ice.TCP.Backlog", 511);

Ice/TcpAcceptor.cpp
201:    _backlog = instance->properties()->getPropertyAsIntWithDefault("Ice.TCP.Backlog", SOMAXCONN);

Ice/BatchRequestQueue.cpp
62:            initData.properties->getPropertyAsIntWithDefault("Ice.UDP.SndSize", 65535 - udpOverhead));

Ice/Instance.cpp
959:                if (_initData.properties->getPropertyAsIntWithDefault("Ice.PrintStackTraces", 1) == 0)

[externl]

As I mentioned when I initially did this there are likely some that are missing and need to be updated.

However, I specifically did not add defaults for properties which do not have one single default, eg. ones where the default value is platform specified, etc. Such as for the ones you've listed above.

They can't use getIcePropety because:

• Ice.TCP.Backlog - depends on language and SOMAXCONN availability
• Ice.TCP/UDP.Snd/RcvSize - depends on OS
• Ice.ThreadPool.Server.Size the default is actually 1, but this code you referenced uses different logic for a different purpose and specifically can't use getIceProperty
• Ice.PrintStackTraces depends on if Ice is compiled for optimize or debug

We shouldn't have a blanket issue (like this one) for this but list specific ones to fix as it's not as simple as grepping.