search

zeroc-ice / ice

All-in-one solution for creating networked applications with RPC, pub/sub, server deployment, and more.
https://zeroc.com
GNU General Public License v2.0
2.03k stars 592 forks source link

Review Python compiler flags #637

Closed externl closed 1 month ago

externl commented 4 years ago

See https://github.com/zeroc-ice/ice/issues/635#issuecomment-554073659

My understanding is that python expect that extensions doesn't link with libpython an so libpython is now behind the new --embed flag that is intended for applications embedding python not for extensions.

b4dc6a8

We have this fix for debian/ubuntu because dh complains that we were linking with libraries that were not required.

for building a python extension we should not be linking with Python, or using the python-config --ldflags we should check what settings are used by pip setup.py builds I think they get the settings from sysconfig

pepone commented 1 month ago

Both the source build and pip build set -undefined dynamic_lookup which I think is the correct thing to do.