Properly Log Errors - Githubissues

zeroc-ice / vscode-slice

Slice syntax highlighter for Visual Studio Code

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

Properly Log Errors #19

Open InsertCreativityHere opened 10 months ago

InsertCreativityHere commented 10 months ago

Currently, whenever we encounter an error (Result::Err I'm talking about), we usually just ignore it by calling ok(), then skipping whatever we were about to do.

It would be better to properly report any actual errors back to the language client, instead of silently hiding them.

ReeceHumphreys commented 8 months ago

Some of this errors should just be emitted to the Slice trace while others emitted to the user in the form of a popup like how https://github.com/zeroc-ice/vscode-slice/commit/0e699639298548ec0ead645f2a0b56e42ecf7c89 does for Diagnostics without spans.