zeroc-ice / vscode-slice

Slice syntax highlighter for Visual Studio Code
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Remove 'Arc' wrapper, and Decouple 'session' and 'client'. #29

Closed InsertCreativityHere closed 6 months ago

InsertCreativityHere commented 6 months ago

This small PR removes the Arc wrapper around Session. Arc is for shared ownership, but there is only a single owner for Sessions, the Backend.

I opened a PR to make sure there isn't some unintended consequence to removing this wrapper. Without Arc, it's now possible to get mutable references to the Session.

It also removes a back-reference where Session held a reference to the Client it was created from. But this is minor.