zeroc-ice / vscode-slice

Slice syntax highlighter for Visual Studio Code
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Tie 'include_built_in_path' and 'built_in_slice_path' together. #33

Closed InsertCreativityHere closed 9 months ago

InsertCreativityHere commented 9 months ago

This PR merges two of the SliceConfig fields into one:

include_built_in_path: bool,
built_in_slice_path: String,

become:

built_in_slice_path: Option<String>,

The bool becomes the Option (true = Some, false = None) And the option holds the actual path inside itself.

This prevents the "Weird case where include_built_in_path is true but built_in_slice_path is empty."

No logic is changed by this PR. It should be strictly equivalent to the current logic.