zeroc-ice / vscode-slice

Slice syntax highlighter for Visual Studio Code
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

We should Run the Language Server over Slice Files Outside Configuration Sets #37

Open InsertCreativityHere opened 9 months ago

InsertCreativityHere commented 9 months ago

Currently, if the user has any configuration sets... configured, we only compile files within those sets. So if there are any files outside the sets, we completely ignore them.

This may be unintuitive to users, and limits the reach of the language server.


Instead, I propose that we always run the language server over every Slice file. If a file is inside a configuration set, we compile the entire set, as we already do. If we find a file not in a configuration set, I think we should still compile it, but as a stand-alone compilation.

But, this may give false diagnostics, ie. They using FooBar which is defined, but isn't found because we're doing a stand-alone compilation.

I see 2 ways to fix this, which are not mutually exclusive: