Currently, we store server-level configuration (the workspace_root and the built_in_slice_paths) in 2 places:
Once (the main one) in Session, but we also store copies of this data in every instance of SliceConfig too.
This PR removes the copies from SliceConfig. Now they're only stored in a single location (Session).
It also introduces a new ServerConfig to hold these data-points, so it's easier to pass around (instead of 2 separate fields).
Any time we need access to the server configuration, instead of using the copy in SliceConfig, we just take a &ServerConfig that the caller passes in.
This change means that we no longer need to fetch the root paths when constructing a SliceConfig.
This actually ends up simplifying alot of code, and lets us introduce Default implementations for a few types too.
Currently, we store server-level configuration (the workspace_root and the built_in_slice_paths) in 2 places: Once (the main one) in
Session, but we also store copies of this data in every instance ofSliceConfigtoo.This PR removes the copies from
SliceConfig. Now they're only stored in a single location (Session). It also introduces a newServerConfigto hold these data-points, so it's easier to pass around (instead of 2 separate fields).Any time we need access to the server configuration, instead of using the copy in
SliceConfig, we just take a&ServerConfigthat the caller passes in.This change means that we no longer need to fetch the root paths when constructing a
SliceConfig. This actually ends up simplifying alot of code, and lets us introduceDefaultimplementations for a few types too.