Fix Highlighting of Metadata in Generic Type Arguments - Githubissues

zeroc-ice / vscode-slice

Slice syntax highlighter for Visual Studio Code

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

Fix Highlighting of Metadata in Generic Type Arguments #53

Closed InsertCreativityHere closed 3 months ago

InsertCreativityHere commented 3 months ago

This PR fixes a bug in the .ice-syntax highlighter where metadata isn't highlighting on types in generic contexts. The bug is just that we don't include the grammar rule for metadata in this place.

I discovered this in the Ice/operations test during the course of https://github.com/zeroc-ice/ice/pull/2023 Before this PR:

Screen Shot 2024-04-08 at 9 10 37 AM

After this PR:

Screen Shot 2024-04-08 at 9 12 43 AM

And here is what it currently looks like on GitHub: https://github.com/zeroc-ice/ice/blob/59392d7b35720e42a07951beeada22e3a60cfa29/cpp/test/Ice/operations/Test.ice#L41