search

zerocd / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

crash when authenticating #242

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
our own auth cache which resides in memory can crash:
if the encrypt/decrypt function for the auth data fails, TSVN tries to 
allocated too much memory because the size isn't initialized. That allocation 
fails and throws an exception which is caught by the crash reporter.

To fix this, we have to check the return values of the encrypt/decrypt APIs and 
initialize the size variables.

and in case encrypting/decrypting fails, we just don't store the auth data in 
our memory cache.

Original issue reported on code.google.com by tortoisesvn on 13 Mar 2012 at 9:34

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r22663.

Original comment by tortoisesvn on 13 Mar 2012 at 9:36

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r22665.

Original comment by tortoisesvn on 13 Mar 2012 at 9:42