search

zerocd / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

Better handle non-versioned items when drop-moving #668

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported on the mailing list:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=30892
74

I encountered this arguably wrong behavior of the >SVN Move versioned item(s) 
here< operation.

In a WC folder I have some modified and some non-versioned items.
If I select one modified and some non-versioned files and drag them with right 
click to a versioned subfolder (not modified)
a context menu appears where one of the options is >SVN Move versioned item(s) 
here<.
If I select it, I get an error dialog:

TortoiseSVN
Path 'C:\path\to\the\​WC\non-versioned-fi​le.txt'
does not exist
[OK]

After clicking OK the operation stops.

The state after is: the modified file was SVN moved to the subfolder, the other 
files left where they were.

Expected: The modified file is moved, the others stay, no error message.
This is arguable. On one hand, I selected the non-versioned files and said >SVN 
move them...<, so I should get an error explaining why no operation was done 
(note, the error mentions only one of them, the other are not mentioned). On 
the other had, it says >SVN Move _versioned_ item(s) here< so it is normal that 
non-versioned files are not affected (so there should be no error reported).

Also the content of the context menu depends on which file I begin the drag 
operation.
If I drag "holding" the modified file, the menu shows >SVN Move versioned 
item(s) here< and >SVN Copy versioned item(s) here<, but if the same files are 
selected but I start the drag from a non-versioned file, the menu shows >SVN 
Copy and add files to this WC< and >SVN Vendorbranch here<.

Original issue reported on code.google.com by tortoisesvn on 7 Oct 2014 at 6:03

GoogleCodeExporter commented 9 years ago 
While some users might expect the non-versioned files to be moved, others want 
to ignore those or moved and added to svn. So we should show an error dialog, 
asking the user what to do with the file:

The file XXX is not versioned.
[move the file]
[move the file and add it to svn]
[skip the file]

[]do this for all non-versioned items

Original comment by tortoisesvn on 7 Oct 2014 at 6:06

GoogleCodeExporter commented 9 years ago 
While I'm at it: the "SVN copy versioned item(s) here" needs the same 
improvement.

Original comment by tortoisesvn on 7 Oct 2014 at 7:40

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r25929.

Original comment by tortoisesvn on 7 Oct 2014 at 8:13