search

zeroclipboard / zeroclipboard-rails

ZeroClipboard rails gem
http://zeroclipboard.org/
MIT License
125 stars 36 forks source link

Update to ZeroClipboard v1.2.0 #9 #10

Closed HaNdTriX closed 10 years ago

HaNdTriX commented 10 years ago

To have something to start with i updated the following files, but i did not test the new version.

So please do not merge until we tested the script.

@myitcv can you please have a look at it?

How do we handle the CSS zoom bug?

myitcv commented 10 years ago

@HaNdTriX - will take a look... specifically at the zoom bug.

Maybe @JamesMGreene can give an update on the status of 'the zoom bug'. I know it was giving him rather too many sleepless nights

myitcv commented 10 years ago

Haven't forgotten about this. Just a bit snowed right now.

JamesMGreene commented 10 years ago

I added a comment to zeroclipboard/ZeroClipboard#149 but forgot to mention it here. So does that bug affect this gem in some bigger way, or do you both just use Reveal.js a lot personally?

myitcv commented 10 years ago

Sorry, very belatedly getting around to this.

Unfortunately the problem still exists in v1.2.2 (just tested with Chrome and Firefox)

@JamesMGreene - the fix that I previously applied to this gem still appears to work if I hack things locally:

https://gist.github.com/myitcv/7396290

Thoughts on doing something like this within the zeroclipboard core package?

myitcv commented 10 years ago

Incidentally I just upgraded to v1.2.2 on another PR. So I suggest we move conversation back to the original issue