zeroclipboard / zeroclipboard.github.io

The ZeroClipboard demo website.
http://zeroclipboard.github.io/
10 stars 16 forks source link

Fix make file #7

Closed rimian closed 10 years ago

rimian commented 10 years ago

Use gh-pages branch as master does not exist Add VERSION to use src files that exist Add a PORT var in case it needs to run on another port

This seems to run OK now.

JamesMGreene commented 10 years ago

This doesn't look equivalent to me but I never really used the Makefile either. @jonrohan?

jonrohan commented 10 years ago

I hadn't had a chance to update this in a while. So glad you took the time to fix for me :sparkles:

rimian commented 10 years ago

@jonrohan thanks for letting me know what the functionality was. It now downloads a tag with curl. It won't download master as the URL won't match but this works for now. :)

jonrohan commented 10 years ago

awesome :metal:

JamesMGreene commented 10 years ago

This still isn't quite right.

Makefile: It should move the files to javascripts/zc/ZeroClipboard_$(VERSION).{js|swf}.

.gitignore: It should exclude ZeroClipboard.{js|swf} at the root (where cURL downloads them).

jonrohan commented 10 years ago

ooops, I've got an itchy merging finger.